Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dpcpp warnings #617

Merged
merged 4 commits into from
Aug 16, 2022
Merged

Conversation

kris-rowe
Copy link
Member

Description

  • Updates the namespace of DPC++ features accepted into the SYCL 2020 spec
  • Corrects address space of atomic references
  • Replaces deprecated barrier calls with group_barrier
  • Reintroduces some DPC++ tests into the CI pipeline

@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #617 (461ef60) into development (a3e3cd1) will not change coverage.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #617   +/-   ##
============================================
  Coverage        77.27%   77.27%           
============================================
  Files              262      262           
  Lines            19571    19571           
============================================
  Hits             15124    15124           
  Misses            4447     4447           
Impacted Files Coverage Δ
src/occa/internal/lang/expr/dpcppAtomicNode.cpp 77.77% <80.00%> (ø)
src/occa/internal/lang/modes/dpcpp.cpp 80.50% <100.00%> (ø)
src/occa/internal/utils/sys.cpp 77.36% <0.00%> (ø)
src/occa/internal/lang/specialMacros.cpp 60.26% <0.00%> (ø)

@kris-rowe kris-rowe merged commit 7e5fd1c into libocca:development Aug 16, 2022
@kris-rowe kris-rowe deleted the fix-dpcpp-warnings branch August 16, 2022 16:47
kris-rowe added a commit that referenced this pull request Dec 16, 2022
* Update the namespace for features accepted into the SYCL 2020 spec.
* Replace deprecated barrier calls with `group_barrier`.
kris-rowe added a commit that referenced this pull request Dec 19, 2022
* Update the namespace for features accepted into the SYCL 2020 spec.
* Replace deprecated barrier calls with `group_barrier`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant