Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 support #258

Merged
merged 1 commit into from
Jan 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on: [ push, pull_request ]
jobs:
CI:
name: ${{ matrix.php }}
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
strategy:
fail-fast: false
matrix:
Expand All @@ -15,21 +15,24 @@ jobs:
- php: '8.1'
- php: '8.2'
- php: '8.3'
- php: '8.3'
- php: '8.4'

steps:
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: ${{ matrix.php }}
ini-values: zend.max_allowed_stack_size=-1
ini-values: zend.max_allowed_stack_size=-1,ffi.enable=true
extensions: ffi, exif
tools: composer:v2
coverage: none

- name: Checkout code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install vips
run: sudo apt install -y libvips --no-install-recommends
run: sudo apt install -y --no-install-recommends libvips

- name: Install composer dependencies
run: |
Expand Down
2 changes: 1 addition & 1 deletion src/Exception.php
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
*/
class Exception extends \Exception
{
public function __construct($message = "", $code = 0, \Throwable $previous = null)
public function __construct($message = "", $code = 0, ?\Throwable $previous = null)
{
if ($message == "") {
$message = "libvips error: " . FFI::vips()->vips_error_buffer();
Expand Down