Don't disconnect on manual force closes #3088
Conversation
lightning/src/ln/channelmanager.rs
Outdated
| /// | ||
| /// By default, this will send a generic force close error message to the peer if `err_msg` | ||
| /// is not specified. If `disconnect_peer` is set to true, the peer will also be disconnected. | ||
| pub fn force_close_broadcasting_latest_txn( |
There was a problem hiding this comment.
Heh, oops, so #2889 already adds the user-provided error message and should be close to merge, you might want to just rebase on that.
Also, I'm not entirely convinced we want to add the disconnection bool - its not clear to me in what case(s) a user would prefer to disconnect a peer vs just sending an error message and calling it a day.
There was a problem hiding this comment.
Heh, oops, so #2889 already adds the user-provided error message and should be close to merge, you might want to just rebase on that.
Oh nice ok
Also, I'm not entirely convinced we want to add the disconnection bool - its not clear to me in what case(s) a user would prefer to disconnect a peer vs just sending an error message and calling it a day.
SGTM, i can just make it so we don't disconnect by default then?
There was a problem hiding this comment.
I was thinking we'd just make it so we never disconnect :)
alecchendev
force-pushed
the
2024-06-fc-no-disconnect
branch
from
97c13b0 to
eb84e4c
Compare
alecchendev
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3088 +/- ##
==========================================
+ Coverage 89.86% 89.88% +0.01%
==========================================
Files 117 117
Lines 97458 97458
Branches 97458 97458
==========================================
+ Hits 87581 87599 +18
+ Misses 7303 7288 -15
+ Partials 2574 2571 -3 ☔ View full report in Codecov by Sentry. |
|
I'm not clear on any cases where the user would actually care about disconnecting the peer, and they can certainly do so manually if they want. |
Previously we'd always disconnect on force close because the peer had done something bad, but on manual force closes that isn't always the case, e.g. when rejecting a new channel request. This just sends an error message by default instead.