Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: remove lfs #12

Merged
merged 5 commits into from
Mar 21, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@ LINHUB_TASK=
PKG_NAME=wsd
PJ_DIR=$PWD
COMPOSE_FILE=./docker/vanilla/compose.yml:./compose.yml
ALLOW_LFS=false
2 changes: 0 additions & 2 deletions .gitattributes

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/trigger.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: CI

on:
push:
branches: ["master", "develop", "v*.*.*", "hotfix/*/*", "fix/*"]
branches: ["master", "develop", "v*.*.*", "hotfix/*/*", "fix/*", "maint/*"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isnt it main ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maint is for maintenance. Doesn't add any features or fix any bugs.

pull_request:
branches: ["master"]

Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,6 @@ wsd/annotate/lit/node_modules
*.iml
.DS_Store
wsd/annotate/lit/package-lock.json

data/*.gz
data/*.zip
15 changes: 8 additions & 7 deletions Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ env:
sh: if command -v rsbuild > /dev/null; then echo "true"; else echo "false"; fi
PJ_DIR:
sh: echo $PWD
JMDICT: "https://drive.usercontent.google.com/download?id=1dlvguHuMjDmtpA4beu1WaVbDte5j4SLk&confirm=yy"
XLWSD: "https://drive.usercontent.google.com/download?id=1d75OUrM3dyAvYUsnBXle-Z1W0NHyKIBD&confirm=yy"
DEV: docker run --rm
-v ${PWD}:/workspace
--workdir /workspace
Expand Down Expand Up @@ -63,7 +65,6 @@ tasks:
cmds:
- sed -i '' 's/__version__ = ".*"/__version__ = "{{.VERSION}}"/' "${PKG_NAME}/__init__.py";
- sed -i '' 's/__build__ = ".*"/__build__ = "{{.BUILD}}"/' "${PKG_NAME}/__init__.py";

add_build.linux:
cmds:
- sed -i "s/__version__ = \".*\"/__version__ = \"{{.VERSION}}\"/" "${PKG_NAME}/__init__.py";
Expand All @@ -86,15 +87,10 @@ tasks:
# Build Tasks
build:
desc: "Tasks related to building the project"
deps: [git_lfs, install_uv, add_build]
deps: [install_uv, add_build, download]
cmds:
- task build.docker

git_lfs:
desc: "Fetch large files"
cmds:
- if [ "$ALLOW_LFS" = "true" ]; then git lfs fetch --all; fi

build.wheel:
desc: "Build the project wheel package"
deps: [install_uv, add_build]
Expand Down Expand Up @@ -125,6 +121,11 @@ tasks:
cmds:
- mesop wsd/annotate/app.py

download:
cmds:
- curl -L "{{.JMDICT}}" -o {{.PJ_DIR}}/data/JMdict_en.gz
- curl -L "{{.XLWSD}}" -o {{.PJ_DIR}}/data/xl-wsd-data.zip

dataset:
cmds:
- gcloud auth application-default login
3 changes: 0 additions & 3 deletions data/JMdict_en.gz

This file was deleted.

1 change: 1 addition & 0 deletions data/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Please run `tasks download` to download the datasets.
3 changes: 0 additions & 3 deletions data/xl-wsd-data.zip

This file was deleted.

1 change: 0 additions & 1 deletion docker/vanilla/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ WORKDIR /workspace
FROM vanilla as dev

RUN apt-get update && apt-get install -y \
git-lfs \
glances \
pre-commit

Expand Down
2 changes: 1 addition & 1 deletion wsd/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
"""Init file containing version and build"""

__version__ = "0.0.1rc0"
__build__ = "Fri Mar 14 15:38:32 JST 2025"
__build__ = "Mon Mar 17 12:31:00 JST 2025"