Separate types for UserApplicationId and ApplicationId. #3582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afck
reviewed
Mar 17, 2025
| UserApplicationId, | ||
| "A unique identifier for a user application" | ||
| ); | ||
| // bcs_scalar!(UserApplicationId, "A unique identifier for a user application"); |
There was a problem hiding this comment.
Must have forgotten to remove it.
| @@ -304,7 +304,45 @@ pub struct ApplicationId<A = ()> { | |||
|
|
|||
| /// Alias for `ApplicationId`. Use this alias in the core | |||
They are used in different contexts:
Maybe we will be able to get rid of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to fix and expand our notion of
Address(currentlyOwner,GenericApplicationId, etc.) to different type of addresses (32-byte Linera/Solana, 20-byte EVM). In order to do that we need to prepare the code for the introduction of new variants.Proposal
Add a separate type for
UserApplicationId(hash)vsApplicationId(a hash + type-safe ABI). Previously the presence ofAtype parameter in "address" enum made it more difficult to refactor. After this PR we have separate types for application's address and application with ABI (used mostly in tests and CLI now).Note: This is an alternative to #3570 . Where I kept the
UserApplicationIdname but promoted it to a newtype.Test Plan
CI should catch regressions.
Release Plan
Links