Fix inclusion of service-as-oracle tests in linera-chain
#3583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvff
force-pushed
the
fix-service-as-oracle-tests-in-linera-chain
branch
from
6e34451 to
d5b0b1a
Compare
deuszx
approved these changes
Mar 17, 2025
Ensure it is enabled by the respective feature in `linera-core`.
Fix the compilation error when attempting to build `linera-chain` tests with the default features.
jvff
force-pushed
the
fix-service-as-oracle-tests-in-linera-chain
branch
from
d5b0b1a to
bed2c0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
On
main, runningcargo test -p linera-chainfails to compile. That happens because some tests assume that thelinera-execution/unstable-oraclesfeature flag was always enabled. CI failed to catch this because all tests are currently being executing with that feature enabled.Proposal
Only include those tests if a new
linera-chain/unstable-oraclesfeature is enabled, which is enabled iflinera-core/unstable-oraclesis enabled.Test Plan
Ran
cargo test -p linera-chainandcargo test -p linera-chain --features unstable-oraclesmanually.CI was not updated because the current plan is to remove
unstable-oraclesin the next few days (#3524).Release Plan
Links