Snowflake ChangeData and BasicCompatibility tests fix #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KushnirykOleh
requested changes
Nov 3, 2022
| @@ -20,8 +20,8 @@ class BasicCompatibilityTestHelper { | |||
| final static String baseChangelogPath = "liquibase/harness/compatibility/basic/changelogs" | |||
| final static List supportedChangeLogFormats = ['xml', 'sql', 'json', 'yml', 'yaml'].asImmutable() | |||
|
|
|||
| static boolean checkConnection(DatabaseConnection connection, String dbName) { | |||
| return connection.isClosed()||connection.getDatabaseProductName().toLowerCase().contains(dbName) | |||
| static boolean checkConnection(DatabaseConnection connection, String... dbNames) { | |||
There was a problem hiding this comment.
rename both checkConnection methods to something like shouldOpenNewConnection(), needNewConnectionForDB(), etc. Something that is like question sentence that can be answered yes or no (true or false)
| @@ -86,4 +87,8 @@ class ChangeDataTestHelper { | |||
| String pathToChangeLogFile | |||
| Database database | |||
| } | |||
|
|
|||
| static boolean checkConnection(DatabaseConnection connection, String... dbNames) { | |||
KushnirykOleh
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.