Adding Verification Levels to Test Support Matrix #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog | ||
| http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-latest.xsd"> | ||
|
|
||
| <!-- Liquibase doesn't support 'dataType' attribute for mariadb, so it is removed comparing to basic changeLog--> |
There was a problem hiding this comment.
need to change mariadb to edb if datatype isn't present for edb as well
| xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog | ||
| http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-latest.xsd"> | ||
|
|
||
| <!-- Liquibase doesn't support 'dataType' attribute for mariadb, so it is removed comparing to basic changeLog--> |
There was a problem hiding this comment.
change mariadb to cockroachdb if dataType attribute isn't present for cockroachdb as well
| xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog | ||
| http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-latest.xsd"> | ||
|
|
||
| <!-- Liquibase doesn't support 'dataType' attribute for mariadb, so it is removed comparing to basic changeLog--> |
There was a problem hiding this comment.
need to change mariadb to cockroachdb if datatype isn't present for cockroachdb as well
| xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog | ||
| http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-latest.xsd"> | ||
|
|
||
| <!-- Liquibase doesn't support 'dataType' attribute for mariadb, so it is removed comparing to basic changeLog--> |
There was a problem hiding this comment.
need to change mariadb to edb if datatype isn't present for edb as well
| xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog | ||
| http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-latest.xsd"> | ||
|
|
||
| <!-- Liquibase doesn't support 'dataType' attribute for mariadb, so it is removed comparing to basic changeLog--> |
There was a problem hiding this comment.
same here need to change mariadb to h2 if datatype isn't supported for h2 as well
...sources/liquibase/harness/generateChangelog/expectedChangeLog/cockroachdb/createFunction.sql
Show resolved
Hide resolved
| @@ -0,0 +1,3 @@ | |||
| INVALID TEST | |||
|
|
|||
| --Indexes are treated as unique constraints during generateChangelog command for Firebird | |||
There was a problem hiding this comment.
is it expected behavior for liquibase?
KushnirykOleh
requested changes
Jan 23, 2023
KushnirykOleh
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating initial proposal