Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merging develop into main after 4.19 release #507

Merged
merged 5 commits into from
Mar 31, 2023
Merged

merging develop into main after 4.19 release #507

merged 5 commits into from
Mar 31, 2023

Conversation

KushnirykOleh
Copy link
Contributor

No description provided.

KushnirykOleh and others added 4 commits December 20, 2022 15:12
@KushnirykOleh @MalloD12
Fix issue 3117 (#392)
2154486 
* Updated expected default value for addDefaultValueComputed sql file based on MySQL changes made for functions

Co-authored-by: Daniel Mallorga <[email protected]>
@KushnirykOleh
Merge pull request #480 from liquibase/fix_mssql_failures
e827b79 
Fix mssql failures
@filipelautert @KushnirykOleh
Add Snowflake double to float tests.
901cf5f
@filipelautert @KushnirykOleh
Add missing json test file.
358c2ce
@vitaliimak vitaliimak self-requested a review February 24, 2023 08:18
@KushnirykOleh
Copy link
Contributor Author

createTableDataTypeDoubleIsFloat test failed when running on develop branch
https://github.com/liquibase/liquibase-test-harness/actions/runs/4255003780/jobs/7402041712#step:7:15647

@KushnirykOleh
Copy link
Contributor Author

@filipelautert @XDelphiGrl when generating snapshot "typeName" for this column is "DOUBLE"
image
Is it expected?

@filipelautert
Copy link
Contributor

@KushnirykOleh for 4.19.1 we merged this PR liquibase/liquibase#3703 that improves DOUBLE type handling for snowflake -> Double is an alias for the FLOAT data type in Snowflake.

@KushnirykOleh
Copy link
Contributor Author

KushnirykOleh commented Mar 10, 2023 •
edited
Loading

Yes, i got that this change was to remove precision where it doesn't need to be.
The issue with this PR is that test fails because expected json contains "typeName": "FLOAT" for FLOATCOL column, but actual typeName is DOUBLE is generated snapshot.
If that doesn't affect generateChnagelog or diff-changelog i can fix expected json and merge that change to develop and then develop to main

@KushnirykOleh
Copy link
Contributor Author

created #529 to fix test to merge develop into main

@KushnirykOleh KushnirykOleh merged commit cc9dc85 into main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaliimak vitaliimak vitaliimak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KushnirykOleh @filipelautert @vitaliimak