Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR-4101:Lowercase SYS.EXTENDED_PROPERTIES and SYS.COLUMNS in expected SQL for table/column remarks. #542

Merged

Conversation

XDelphiGrl
Copy link
Contributor

@XDelphiGrl XDelphiGrl commented May 2, 2023

PR liquibase/liquibase#4101 fixes a SQL Server bug generating table and column remarks on a SQL Server instance with case-sensitive collation defined. This PR updates the expectedSQL files for the test cases:

  • apply setColumnRemarks against mssql
  • apply setTableRemarks against mssql

Test Execution against Fix Branch: https://github.com/liquibase/liquibase-test-harness/actions/runs/4863405218

@XDelphiGrl XDelphiGrl changed the base branch from main to develop May 2, 2023 16:16
@KushnirykOleh KushnirykOleh marked this pull request as ready for review May 3, 2023 11:51
@KushnirykOleh
Copy link
Contributor

as corresponding liquibase(core) PR is merged to master we need to merge this PR to develop branch

@KushnirykOleh KushnirykOleh merged commit 75717bd into develop May 3, 2023
@KushnirykOleh KushnirykOleh deleted the 4096_mssql_case_sensitive_sys_extended_properties branch May 3, 2023 11:52
@KushnirykOleh KushnirykOleh mentioned this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants