Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MySQL boolean behaviour from TinyInt(1) to TinyInt #641

Merged
merged 19 commits into from
Dec 14, 2023

Conversation

MalloD12
Copy link
Contributor

Some time ago we made some updates for MySQL DB where Boolean data type was stored as TinyInt(1) (See #584). From version 8.0.17 that's changing and now it's deploying Boolean just as TinyInt, otherwise it will throw a warning for now because "Integer display width is deprecated and will be removed in a future release".

For more information see this comment: liquibase/liquibase#4090 (comment)

Core Related PR: liquibase/liquibase#5130

@MalloD12
Copy link
Contributor Author

@PavloTytarchuk - @KushnirykOleh: I have created this PR to update the tinyInt changes we made some time ago for boolean data type. I'll keep you posted when we merge the core PR so you guys can review and merge this one if everything is ok.

Thanks,
Daniel.

KushnirykOleh and others added 18 commits December 5, 2023 11:08
…nd performance

chore(main.yml): update Java version to 17 for better compatibility and performance
The command syntax for installing liquibase snapshot was incorrect. The command has been updated to use the correct syntax for installing the snapshot.
…ts to mvn liquibase-sdk:install-snapshot-cli
…tiple repositories and custom Liquibase home directory

feat(pom.xml): enable automatic installation of Liquibase if not found in the specified Liquibase home directory
…ild process

The Liquibase SDK snapshot is now being installed during the build process. This allows for the usage of the Liquibase SDK in subsequent steps. The installation is done using the Liquibase branch specified in the `configure-build` step, along with the repositories `liquibase/liquibase` and `liquibase/liquibase-pro`. Additionally, the workflow IDs `build.yml` and `run-tests.yml` are provided for the Pro and non-Pro workflows respectively. The installed snapshot version is then displayed in the build overview.
…emove unnecessary arguments

feat(main.yml): update Maven commands to install Liquibase snapshot with improved branch search and repository configuration
…0.23 to 0.10.22 to resolve compatibility issues
…2 to 0.10.23 for bug fixes and improvements

chore(pom.xml): remove liquibase-pro repository from liquibase-sdk-maven-plugin configuration as it is no longer needed
…ugin

The repo configuration in the liquibase plugin is not needed as it defaults to the current repository. Removing it improves the clarity and simplicity of the configuration.
…formation

chore(main.yml): remove commented out buildOverview commands to improve code readability
…t command

The command was removed as it was no longer needed and was causing unnecessary overhead during the build process.
…all snapshot Liquibase

The command `mvn liquibase-sdk:install-snapshot` is added to the workflow to install the snapshot version of Liquibase. This command takes the following parameters:
- `-Dliquibase.sdk.branchSearch=${{ steps.configure-build.outputs.liquibaseBranch }},master,main,develop`: This parameter specifies the branch search order for the Liquibase SDK. It searches for the specified branches in the given order to find the Liquibase SDK.
- `-Dliquibase.sdk.repo=liquibase/liquibase,liquibase/liquibase-pro`: This parameter specifies the repositories to search for the Liquibase SDK. It searches for the Liquibase SDK in the `liquibase/liquibase` and `liquibase/liquibase-pro` repositories.

This change ensures that the snapshot version of Liquibase is installed during the workflow execution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants