DAT-16491 : get liquibase-core working with develop branch #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd performance chore(main.yml): update Java version to 17 for better compatibility and performance
* Bump whelk-io/maven-settings-xml-action from 20 to 21 Bumps [whelk-io/maven-settings-xml-action](https://github.com/whelk-io/maven-settings-xml-action) from 20 to 21. - [Release notes](https://github.com/whelk-io/maven-settings-xml-action/releases) - [Commits](whelk-io/maven-settings-xml-action@v20...v21) --- updated-dependencies: - dependency-name: whelk-io/maven-settings-xml-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Bump liquibase-github-actions/drop-all from 4.24.0 to 4.25.0 Bumps [liquibase-github-actions/drop-all](https://github.com/liquibase-github-actions/drop-all) from 4.24.0 to 4.25.0. - [Release notes](https://github.com/liquibase-github-actions/drop-all/releases) - [Commits](liquibase-github-actions/drop-all@v4.24.0...v4.25.0) --- updated-dependencies: - dependency-name: liquibase-github-actions/drop-all dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump actions/github-script from 7.0.0 to 7.0.1 Bumps [actions/github-script](https://github.com/actions/github-script) from 7.0.0 to 7.0.1. - [Release notes](https://github.com/actions/github-script/releases) - [Commits](actions/github-script@v7.0.0...v7.0.1) --- updated-dependencies: - dependency-name: actions/github-script dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Bump com.ibm.db2:jcc from 11.5.8.0 to 11.5.9.0 Bumps com.ibm.db2:jcc from 11.5.8.0 to 11.5.9.0. --- updated-dependencies: - dependency-name: com.ibm.db2:jcc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Bump org.codehaus.mojo:versions-maven-plugin from 2.16.1 to 2.16.2 Bumps [org.codehaus.mojo:versions-maven-plugin](https://github.com/mojohaus/versions) from 2.16.1 to 2.16.2. - [Release notes](https://github.com/mojohaus/versions/releases) - [Changelog](https://github.com/mojohaus/versions/blob/master/ReleaseNotes.md) - [Commits](mojohaus/versions@2.16.1...2.16.2) --- updated-dependencies: - dependency-name: org.codehaus.mojo:versions-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Bump org.postgresql:postgresql from 42.6.0 to 42.7.0 Bumps [org.postgresql:postgresql](https://github.com/pgjdbc/pgjdbc) from 42.6.0 to 42.7.0. - [Release notes](https://github.com/pgjdbc/pgjdbc/releases) - [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md) - [Commits](pgjdbc/pgjdbc@REL42.6.0...REL42.7.0) --- updated-dependencies: - dependency-name: org.postgresql:postgresql dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Bump org.firebirdsql.jdbc:jaybird from 5.0.2.java11 to 5.0.3.java11 Bumps [org.firebirdsql.jdbc:jaybird](https://github.com/FirebirdSQL/jaybird) from 5.0.2.java11 to 5.0.3.java11. - [Release notes](https://github.com/FirebirdSQL/jaybird/releases) - [Commits](https://github.com/FirebirdSQL/jaybird/commits) --- updated-dependencies: - dependency-name: org.firebirdsql.jdbc:jaybird dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * using Codex-/return-dispatch to get the run-id for OSS when a run is triggered (#666) * fix error unexpected end of the stream within a double quoted scalar (#667) * Bump org.xerial:sqlite-jdbc from 3.44.0.0 to 3.44.1.0 Bumps [org.xerial:sqlite-jdbc](https://github.com/xerial/sqlite-jdbc) from 3.44.0.0 to 3.44.1.0. - [Release notes](https://github.com/xerial/sqlite-jdbc/releases) - [Changelog](https://github.com/xerial/sqlite-jdbc/blob/master/CHANGELOG) - [Commits](xerial/sqlite-jdbc@3.44.0.0...3.44.1.0) --- updated-dependencies: - dependency-name: org.xerial:sqlite-jdbc dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Bump commons-io:commons-io from 2.15.0 to 2.15.1 Bumps commons-io:commons-io from 2.15.0 to 2.15.1. --- updated-dependencies: - dependency-name: commons-io:commons-io dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Bump org.mariadb.jdbc:mariadb-java-client from 3.3.0 to 3.3.1 Bumps [org.mariadb.jdbc:mariadb-java-client](https://github.com/mariadb-corporation/mariadb-connector-j) from 3.3.0 to 3.3.1. - [Release notes](https://github.com/mariadb-corporation/mariadb-connector-j/releases) - [Changelog](https://github.com/mariadb-corporation/mariadb-connector-j/blob/master/CHANGELOG.md) - [Commits](mariadb-corporation/mariadb-connector-j@3.3.0...3.3.1) --- updated-dependencies: - dependency-name: org.mariadb.jdbc:mariadb-java-client dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Bump actions/setup-java from 3 to 4 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3 to 4. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v3...v4) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Bump org.apache.maven.plugins:maven-javadoc-plugin from 3.6.2 to 3.6.3 Bumps [org.apache.maven.plugins:maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.6.2 to 3.6.3. - [Release notes](https://github.com/apache/maven-javadoc-plugin/releases) - [Commits](apache/maven-javadoc-plugin@maven-javadoc-plugin-3.6.2...maven-javadoc-plugin-3.6.3) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-javadoc-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Bump org.postgresql:postgresql from 42.7.0 to 42.7.1 Bumps [org.postgresql:postgresql](https://github.com/pgjdbc/pgjdbc) from 42.7.0 to 42.7.1. - [Release notes](https://github.com/pgjdbc/pgjdbc/releases) - [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md) - [Commits](pgjdbc/pgjdbc@REL42.7.0...REL42.7.1) --- updated-dependencies: - dependency-name: org.postgresql:postgresql dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Bump org.liquibase.ext:liquibase-sdk-maven-plugin Bumps [org.liquibase.ext:liquibase-sdk-maven-plugin](https://github.com/liquibase/liquibase-sdk-maven-plugin) from 0.10.22 to 0.10.23. - [Release notes](https://github.com/liquibase/liquibase-sdk-maven-plugin/releases) - [Commits](liquibase/liquibase-sdk-maven-plugin@v0.10.22...v0.10.23) --- updated-dependencies: - dependency-name: org.liquibase.ext:liquibase-sdk-maven-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Bump net.snowflake:snowflake-jdbc from 3.14.3 to 3.14.4 Bumps [net.snowflake:snowflake-jdbc](https://github.com/snowflakedb/snowflake-jdbc) from 3.14.3 to 3.14.4. - [Release notes](https://github.com/snowflakedb/snowflake-jdbc/releases) - [Changelog](https://github.com/snowflakedb/snowflake-jdbc/blob/master/CHANGELOG.rst) - [Commits](snowflakedb/snowflake-jdbc@v3.14.3...v3.14.4) --- updated-dependencies: - dependency-name: net.snowflake:snowflake-jdbc dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * DAT-16380 (#673) * using -Dliquibase.sdk.workflowId=run-tests.yml * use sdk-maven-plugin 0.10.23 * get liquibase --version * get branch develop * Trigger build --------- Co-authored-by: Sayali M <sayali@Sayalis-MacBook-Pro> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: KushnirykOleh <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vitalii Makarchenkov <[email protected]> Co-authored-by: Sayali M <sayali@Sayalis-MacBook-Pro>
The command syntax for installing liquibase snapshot was incorrect. The command has been updated to use the correct syntax for installing the snapshot.
…ts to mvn liquibase-sdk:install-snapshot-cli
…tiple repositories and custom Liquibase home directory feat(pom.xml): enable automatic installation of Liquibase if not found in the specified Liquibase home directory
…ild process The Liquibase SDK snapshot is now being installed during the build process. This allows for the usage of the Liquibase SDK in subsequent steps. The installation is done using the Liquibase branch specified in the `configure-build` step, along with the repositories `liquibase/liquibase` and `liquibase/liquibase-pro`. Additionally, the workflow IDs `build.yml` and `run-tests.yml` are provided for the Pro and non-Pro workflows respectively. The installed snapshot version is then displayed in the build overview.
…emove unnecessary arguments feat(main.yml): update Maven commands to install Liquibase snapshot with improved branch search and repository configuration
… and reduce noise in the build logs
… branch for snapshot installation
…0.23 to 0.10.22 to resolve compatibility issues
…2 to 0.10.23 for bug fixes and improvements chore(pom.xml): remove liquibase-pro repository from liquibase-sdk-maven-plugin configuration as it is no longer needed
…ugin The repo configuration in the liquibase plugin is not needed as it defaults to the current repository. Removing it improves the clarity and simplicity of the configuration.
…formation chore(main.yml): remove commented out buildOverview commands to improve code readability
…t command The command was removed as it was no longer needed and was causing unnecessary overhead during the build process.
…all snapshot Liquibase
The command `mvn liquibase-sdk:install-snapshot` is added to the workflow to install the snapshot version of Liquibase. This command takes the following parameters:
- `-Dliquibase.sdk.branchSearch=${{ steps.configure-build.outputs.liquibaseBranch }},master,main,develop`: This parameter specifies the branch search order for the Liquibase SDK. It searches for the specified branches in the given order to find the Liquibase SDK.
- `-Dliquibase.sdk.repo=liquibase/liquibase,liquibase/liquibase-pro`: This parameter specifies the repositories to search for the Liquibase SDK. It searches for the Liquibase SDK in the `liquibase/liquibase` and `liquibase/liquibase-pro` repositories.
This change ensures that the snapshot version of Liquibase is installed during the workflow execution.
…he maven-scm-plugin The liquibaseHome configuration is added to specify the location of the Liquibase binary. This allows the plugin to find and execute Liquibase commands. The allowInstall configuration is added to enable the installation of Liquibase if it is not found in the specified liquibaseHome location. This ensures that Liquibase is available for the plugin to use.
…T and install snapshot CLI The changes in this commit add two new steps to the main.yml workflow file. The first step uses the `mvn versions:set-property` command to set the `liquibase-core.version` property to `0-SNAPSHOT`. This is done to update the version of the liquibase-core library used in the project. The second step uses the `mvn liquibase-sdk:install-snapshot-cli` command to install the snapshot CLI for the liquibase-sdk. This step also includes additional parameters to specify the branch search order and the repositories to search for the liquibase-sdk. These changes are made to ensure that the liquibase-core version is set to the desired value and to install the necessary tools for working with the liquibase-sdk.
…ange permissions for bin directory The commented out code is unnecessary and adds clutter to the workflow file. Removing it improves readability and maintainability. Additionally, the step to change permissions for the bin directory was missing. This step is necessary to ensure that the bin directory has the correct permissions for the subsequent commands to execute successfully.
Expected SQL files updated to reflect MariaDB boolean changes from OSS
made fixes in expected snapshots for mariadb boolean tests
sayaliM0412
requested review from
KushnirykOleh,
yodzhubeiskyi and
filipelautert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.github/workflows/main.yml: removecheck_build_safetyjob as we are usingauthorizeand removing usage ofuseLiquibaseSnapshotsrc/main/resources/liquibase/harness/change/expectedSnapshot/mariadb/addDefaultValueBoolean.jsonsrc/main/resources/liquibase/harness/change/expectedSnapshot/mariadb/addNotNullConstraintBitBoolean.jsonsrc/main/resources/liquibase/harness/change/expectedSql/mariadb/addDefaultValueBoolean.sqlsrc/main/resources/liquibase/harness/change/expectedSql/mariadb/addNotNullConstraintBitBoolean.sql