-
Notifications
You must be signed in to change notification settings - Fork 80
Add ForwardDestRoom to VideoGrant #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 0ead5b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
packages/livekit-server-sdk/src/RoomServiceClient.ts:242
- [nitpick] The parameter key 'forwardDestRoom' is being assigned 'destinationRoom'. Consider aligning the naming between the variable and the parameter for clarity.
await this.authHeader({ roomAdmin: true, room, forwardDestRoom: destinationRoom }),
.changeset/old-berries-scream.md
Outdated
'livekit-server-sdk': minor | ||
--- | ||
|
||
Add FowardDestRoom to VideoGrant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a spelling error in 'FowardDestRoom'; consider correcting it to 'ForwardDestRoom' to maintain consistency with the code.
Add FowardDestRoom to VideoGrant | |
Add ForwardDestRoom to VideoGrant |
Copilot uses AI. Check for mistakes.
.changeset/old-berries-scream.md
Outdated
'livekit-server-sdk': minor | ||
--- | ||
|
||
Add FowardDestRoom to VideoGrant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot caught it, the spelling
Co-authored-by: David Zhao <[email protected]>
No description provided.