Skip to content

Add ForwardDestRoom to VideoGrant #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025
Merged

Add ForwardDestRoom to VideoGrant #460

merged 3 commits into from
Apr 9, 2025

Conversation

cnderrauber
Copy link
Contributor

No description provided.

Verified

This commit was signed with the committer’s verified signature.
laurit Lauri Tulmin
Copy link

changeset-bot bot commented Apr 9, 2025

🦋 Changeset detected

Latest commit: 0ead5b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
livekit-server-sdk Minor
agent-dispatch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

packages/livekit-server-sdk/src/RoomServiceClient.ts:242

  • [nitpick] The parameter key 'forwardDestRoom' is being assigned 'destinationRoom'. Consider aligning the naming between the variable and the parameter for clarity.
await this.authHeader({ roomAdmin: true, room, forwardDestRoom: destinationRoom }),

'livekit-server-sdk': minor
---

Add FowardDestRoom to VideoGrant
Copy link
Preview

Copilot AI Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a spelling error in 'FowardDestRoom'; consider correcting it to 'ForwardDestRoom' to maintain consistency with the code.

Suggested change
Add FowardDestRoom to VideoGrant
Add ForwardDestRoom to VideoGrant

Copilot uses AI. Check for mistakes.

'livekit-server-sdk': minor
---

Add FowardDestRoom to VideoGrant
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot caught it, the spelling

cnderrauber and others added 2 commits April 9, 2025 14:14
Co-authored-by: David Zhao <[email protected]>
@cnderrauber cnderrauber merged commit 2765463 into main Apr 9, 2025
13 checks passed
@cnderrauber cnderrauber deleted the forward_grant branch April 9, 2025 06:39
@github-actions github-actions bot mentioned this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants