Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CI to use protobuf 4.x #396

Merged
merged 2 commits into from
Mar 14, 2025
Merged

update CI to use protobuf 4.x #396

merged 2 commits into from
Mar 14, 2025

Conversation

davidzhao
Copy link
Member

@davidzhao davidzhao commented Mar 14, 2025

some folks are still using Protobuf 4.x in their projects. if we generate protobuf python files with v5, it would refuse to load when a user is on protobuf v4

@davidzhao davidzhao marked this pull request as ready for review March 14, 2025 03:15
@davidzhao davidzhao requested a review from a team March 14, 2025 03:17
@davidzhao davidzhao merged commit 28bcb73 into main Mar 14, 2025
4 checks passed
@davidzhao davidzhao deleted the downgrade-proto branch March 14, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants