Add flang-arm64-windows-msvc buildbot #398
Conversation
This patch introduces a dedicated flang-arm64-windows-msvc buildbot to decouple Flang from the existing Clang buildbot splitting load. This will test flang with openmp and flang-rt runtimes and will run check-mlir, check-flang, and check-flang-rt.
This is a follow up patch from llvm#398 and it removes Flang from the clang-arm64-windows-msvc builder. This patch also introduces the following changes to clang-arm64-windows-msvc: 1) Switches to UnifiedTreeBuilder 2) Enables LLVM_ENABLE_RUNTIMES=compiler-rt;openmp 3) Restricts DLLVM_TARGETS_TO_BUILD to AArch64, ARM, and X86
There was a problem hiding this comment.
You said this is to spread the work. I don't recall out of memory errors on Windows on Arm, which is the usual problem we have with Flang, so is it purely so that Clang can build more frequently?
You could also argue that we have separate Clang and Flang bots for Linux, so this change aligns Windows with that.
Also this is single stage, right? So the current 2 stage bot will still be building Flang with stage 1's Clang. That seems valauble enough to keep Flang enabled there.
This is not to divide the load based on memory usage but rather done to split the testsuite execution time. The common observation in recent months is that more often we have a failing flang test or build failure in flang rather than rest of the llvm project but check llvm and check clang take most of the time during testsuite check-all. With this builder we will be able to run flang testsuite early hence catching problems way earlier.
Agreed.
Yes for now there is no plan to change the 2 stage bot although it has a long execution time but that can only be fixed with better hardware. |
|
I didn't even consider the testing time. With all the given reasons, I agree this is a good change. |
| 'factory' : UnifiedTreeBuilder.getCmakeWithNinjaBuildFactory( | ||
| depends_on_projects=['llvm', 'clang', 'lld', 'mlir', 'compiler-rt', 'openmp', 'flang','flang-rt'], | ||
| checks=['check-mlir', 'check-flang', 'check-flang-rt'], | ||
| extra_configure_args=[ |
There was a problem hiding this comment.
It would be nice to enable assertions, to catch more issues: -DLLVM_ENABLE_ASSERTIONS=ON
There was a problem hiding this comment.
UnifiedTreeBuilder enables DLLVM_ENABLE_ASSERTIONS=ON by default so we dont have to mention it explicitly in the configure flags.
This is a follow up patch from #398 and it removes Flang from the clang-arm64-windows-msvc builder. This patch also introduces the following changes to clang-arm64-windows-msvc: 1) Switches to UnifiedTreeBuilder 2) Enables LLVM_ENABLE_RUNTIMES=compiler-rt;openmp 3) Restricts DLLVM_TARGETS_TO_BUILD to AArch64, ARM, and X86
This patch introduces a dedicated flang-arm64-windows-msvc buildbot to decouple Flang from the existing Clang buildbot splitting load.
This will test flang with openmp and flang-rt runtimes and will run check-mlir, check-flang, and check-flang-rt.