-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate SDKs for Looker 23.4 #1290
Conversation
Release-As: 23.4.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Go Tests 6 files ±0 6 suites ±0 13m 42s ⏱️ + 1m 35s For more details on these failures, see this check. Results for commit 3c2bd9b. ± Comparison against base commit 44974ec. |
Python Tests 10 files 10 suites 3m 44s ⏱️ Results for commit 3c2bd9b. |
Typescript Tests 6 files 56 suites 13m 27s ⏱️ Results for commit 3c2bd9b. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
* Update state variables before moving to redux * Updating state variable names * fix isConfigured function * fix: Set Go SDK's User-Agent header (#1285) Implement AgentTag defined in settings and set Go SDK's outgoing Do requests with the User-Agent header. Fixes issue: #1274 --------- Co-authored-by: Colin Gooding <[email protected]> * fix: Implement Go SDK timeout (#1287) Implement the Timeout field in our config/settings. Make use of request context to control timeout. Timeout defaults to 120 seconds. Hopefully the unit tests are not flaky with the new timeout tests. Fixes issue #692 * feat: generate SDKs for Looker 23.4 (#1290) Release-As: 23.4.0 * chore: release main (#1281) * feat: Add Go SDK custom header support and README (#1288) Following our node sdk's design, allow developers to set custom headers on Go SDK requests. Request specific custom headers will override headers defined in the sdk's settings/config. This will allow the Go SDK caller to set Accept headers and other custom headers. Also add README for Go SDK. Also fixes issue stated in #1075. (Not the main one, but other one brought up by Go SDK users) * Updating OAuthForm function names --------- Co-authored-by: jeremytchang <[email protected]> Co-authored-by: Colin Gooding <[email protected]> Co-authored-by: looker-open-source-automation-bot <[email protected]>
Release-As: 23.4.0