Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate SDKs for Looker 23.4 #1290

Merged
merged 1 commit into from
Mar 31, 2023
Merged

feat: generate SDKs for Looker 23.4 #1290

merged 1 commit into from
Mar 31, 2023

Conversation

jeremytchang
Copy link
Collaborator

Release-As: 23.4.0

Copy link
Collaborator

@drstrangelooker drstrangelooker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Go Tests

    6 files  ±0      6 suites  ±0   13m 42s ⏱️ + 1m 35s
  49 tests ±0    47 ✔️  - 2  0 💤 ±0  2 ❌ +2 
118 runs  ±0  116 ✔️  - 2  0 💤 ±0  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 3c2bd9b. ± Comparison against base commit 44974ec.

@github-actions
Copy link
Contributor

Python Tests

  10 files    10 suites   3m 44s ⏱️
144 tests 141 ✔️   3 💤 0 ❌
792 runs  780 ✔️ 12 💤 0 ❌

Results for commit 3c2bd9b.

@github-actions
Copy link
Contributor

Go Tests

    6 files  ±0      6 suites  ±0   12m 41s ⏱️ +34s
  49 tests ±0    49 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
118 runs  ±0  118 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3c2bd9b. ± Comparison against base commit 44974ec.

@github-actions
Copy link
Contributor

Typescript Tests

    6 files    56 suites   13m 27s ⏱️
200 tests 196 ✔️   4 💤 0 ❌
494 runs  478 ✔️ 16 💤 0 ❌

Results for commit 3c2bd9b.

@jeremytchang jeremytchang merged commit d7cd650 into main Mar 31, 2023
@jeremytchang jeremytchang deleted the sdk_23_4 branch March 31, 2023 22:27
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

zeckertG pushed a commit that referenced this pull request Apr 7, 2023
zeckertG added a commit that referenced this pull request Apr 11, 2023
* Update state variables before moving to redux

* Updating state variable names

* fix isConfigured function

* fix: Set Go SDK's User-Agent header (#1285)

Implement AgentTag defined in settings and set Go SDK's outgoing Do requests with the User-Agent header.

Fixes issue: #1274

---------

Co-authored-by: Colin Gooding <[email protected]>

* fix: Implement Go SDK timeout (#1287)

Implement the Timeout field in our config/settings. Make use of request context to control timeout. Timeout defaults to 120 seconds. Hopefully the unit tests are not flaky with the new timeout tests.

Fixes issue #692

* feat: generate SDKs for Looker 23.4 (#1290)

Release-As: 23.4.0

* chore: release main (#1281)

* feat: Add Go SDK custom header support and README (#1288)

Following our node sdk's design, allow developers to set custom headers on Go SDK requests. Request specific custom headers will override headers defined in the sdk's settings/config. This will allow the Go SDK caller to set Accept headers and other custom headers. Also add README for Go SDK.

Also fixes issue stated in #1075. (Not the main one, but other one brought up by Go SDK users)

* Updating OAuthForm function names

---------

Co-authored-by: jeremytchang <[email protected]>
Co-authored-by: Colin Gooding <[email protected]>
Co-authored-by: looker-open-source-automation-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants