fix: Set Go SDK's User-Agent header #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryans99
reviewed
Mar 28, 2023
|
@bryans99 Thanks! Please approve. Technically this is another developer's changes that i'm approving, but i have to create this PR for it to pass CI. |
bryans99
approved these changes
Mar 28, 2023
Merged
This comment has been minimized.
This comment has been minimized.
zeckertG
pushed a commit
that referenced
this pull request
Apr 7, 2023
Implement AgentTag defined in settings and set Go SDK's outgoing Do requests with the User-Agent header. Fixes issue: #1274 --------- Co-authored-by: Colin Gooding <[email protected]>
zeckertG
added a commit
that referenced
this pull request
Apr 11, 2023
* Update state variables before moving to redux * Updating state variable names * fix isConfigured function * fix: Set Go SDK's User-Agent header (#1285) Implement AgentTag defined in settings and set Go SDK's outgoing Do requests with the User-Agent header. Fixes issue: #1274 --------- Co-authored-by: Colin Gooding <[email protected]> * fix: Implement Go SDK timeout (#1287) Implement the Timeout field in our config/settings. Make use of request context to control timeout. Timeout defaults to 120 seconds. Hopefully the unit tests are not flaky with the new timeout tests. Fixes issue #692 * feat: generate SDKs for Looker 23.4 (#1290) Release-As: 23.4.0 * chore: release main (#1281) * feat: Add Go SDK custom header support and README (#1288) Following our node sdk's design, allow developers to set custom headers on Go SDK requests. Request specific custom headers will override headers defined in the sdk's settings/config. This will allow the Go SDK caller to set Accept headers and other custom headers. Also add README for Go SDK. Also fixes issue stated in #1075. (Not the main one, but other one brought up by Go SDK users) * Updating OAuthForm function names --------- Co-authored-by: jeremytchang <[email protected]> Co-authored-by: Colin Gooding <[email protected]> Co-authored-by: looker-open-source-automation-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
AgentTagdefined in settings and set Go SDK's outgoingDorequests with the User-Agent header.Fixes issue: #1274