-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Bump attrs, cattrs versions for Python 3.7+ #374
[Python] Bump attrs, cattrs versions for Python 3.7+ #374
Conversation
thanks for finding this. We need to maintain support for python 3.6 and it looks like that was dropped in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have cycles to figure out allowing higher cattrs
versions conditional on python version that would be much appreciated! Otherwise for now let's just pin it to 1.0.0
so new installations aren't broken
Thanks Joel! I can get this in place later today. |
@joeldodge79 : Done. Tested installing on my brand new venvs on 36 and 37, and the right versions get installed on both. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you! I'll get this published shortly
Thanks Joel! |
Ran into a weird edge case today where import for
looker_sdk
failed because of a version issue withattrs
, which was on19.3.0
butcattrs
requiredattr>=20.1.0
(this line requires attrs > 20.1.0). Tracelog below, but running apip install -U attrs
fixed the issue. Bumping it up in here, along with the version (feel free to update the version appropriately if that's an error on my end).Tracelog: