DM-49474: Add flag to install a specific rubin-env #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwittgen
force-pushed
the
tickets/DM-49474
branch
2 times, most recently
from
275b804 to
6cc0ab2
Compare
ktlim
approved these changes
Mar 18, 2025
| @@ -225,7 +229,7 @@ main() { | |||
| if [[ -n $TAG ]]; then | |||
| ARGS+=("--file" "${TAG}.env") | |||
| else | |||
| ARGS+=("rubin-env=${RUBIN_ENV_VERSION}") | |||
| ARGS+=("${LSST_RUBIN_ENV_NAME}=${RUBIN_ENV_VERSION}") | |||
There was a problem hiding this comment.
Since bin/deploy is for developers anyway, I guess it's OK that this now allows installation of any conda package instead of rubin-env.
There was a problem hiding this comment.
Added some additional checks
There was a problem hiding this comment.
My only comment is whether -R is a good flag or not. Otherwise this looks good to me
mwittgen
force-pushed
the
tickets/DM-49474
branch
from
1c2af78 to
fbbc786
Compare
mwittgen
force-pushed
the
tickets/DM-49474
branch
from
fbbc786 to
d239030
Compare
mwittgen
force-pushed
the
tickets/DM-49474
branch
from
9f40aa9 to
acda278
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.