Quick fix for Wrong Test method with last Nunit3TestAdapter #57 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,10 +44,15 @@ private static bool HasPdb(MethodBase methodBase) | |||
| lock (Lock) | |||
| { | |||
| if (AssemblyHasPdbCache.TryGetValue(location, out var hasPdb)) return hasPdb; | |||
| hasPdb = File.Exists(Path.ChangeExtension(location, ".pdb")); | |||
| hasPdb = IsNotATestFrameworkAssembly(methodBase.DeclaringType.Assembly) && File.Exists(Path.ChangeExtension(location, ".pdb")); | |||
There was a problem hiding this comment.
Maybe rename hasPdb to isUserAssembly. Or something different.
Not a blocker.
There was a problem hiding this comment.
Yes I was thinking the same
|
|
||
| private static bool IsNotATestFrameworkAssembly(Assembly assembly) | ||
| { | ||
| return !TestFrameworkAssemblies.Any(framework => assembly.GetName().Name.Equals(framework, StringComparison.InvariantCultureIgnoreCase)); |
There was a problem hiding this comment.
Since this method might be called several times in some situations, maybe it's better to use a Hashset and lose the IgnoreCase comparison. O(1) vs O(n)
| AssemblyHasPdbCache.Add(location, hasPdb); | ||
| return hasPdb; | ||
| } | ||
| } | ||
|
|
||
| private static bool IsNotATestFrameworkAssembly(Assembly assembly) |
There was a problem hiding this comment.
I slightly prefer a positive method: IsTestFrameworkAssembly
And negate where we call the method.
But this is not a blocker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I wrote it in the issue we should do a small instrumentation on Test assemblies that would add an attribute on hit so that we don't need to know tests frameworks
Also would improve execution as then we don't need to instrument every thing with the try catch only the Test assemblies