-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BREAKING] Multi-threading of CommonSolve functions #17
Open
lxvm
wants to merge
29
commits into
main
Choose a base branch
from
thread
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
- Coverage 86.32% 82.50% -3.83%
==========================================
Files 19 20 +1
Lines 1324 1509 +185
==========================================
+ Hits 1143 1245 +102
- Misses 181 264 +83 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr will enable multi-threading of
CommonSolveIntegralFunction
andCommonSolveFourierIntegralFunction
. This should be beneficial for costly integrands which take longer than a millisecond to solve as well as for parallelizingNestedQuad
.TODO:
CommonSolveIntegralFunction
parallelization for remaining algorithmsCommonSolveFourierIntegralFunction
parallelization for all algorithms.AbstractSpecialization
andAbstractExecutor
interfacesEvalCounter
to work with the multi-threadingexecutor
,specialization
, andEvalCounter
with examplesexecutor
andspecialization
interfacesNOTES:
NestedQuad
tolerances are set in inner integrals. Previously, tolerances were set atinit
time (sometimes incorrectly in the case ofAutoBZProblem
s) and only the outer integral tolerance was updated to the desired tolerance atsolve!
time, but inner integrals were stuck with the tolerances provided atinit
time. Now, the tolerance provided atsolve!
time is used by all nested integrals, hopefully with improved performance.CommonSolveIntegralFunction
interface changed, replacing(update!, postsolve)
pair for a singlesolve!
functionnthreads
keywords removed fromMonkhorstPack, PTR, AutoSymPTR, and AutoPTR
algorithmsexecutor
interface introduced forIntegralFunction, CommonSolveFourierIntegralFunction, FourierIntegralFunction, CommonSolveFourierIntegralFunction, NestedQuad, IAI
in order to control serial vs multi-threaded executionspecialization
interface introduced forCommonSolveFourierIntegralFunction, CommonSolveFourierIntegralFunction, NestedQuad, IAI
to control the tradeoff of compilation vs runtime performance