Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qp 454 improve wheel perf #13

Merged
2 commits merged into from
Oct 18, 2019
Merged

Qp 454 improve wheel perf #13

2 commits merged into from
Oct 18, 2019
+84 −57

Conversation

ghost
Copy link

@ghost ghost commented Oct 17, 2019

This does a few things with the intention of improving performance of zoom.

  • Use an animation frame for wheel events.
  • Move the wheel event to addEventListener to fix the warning about calling preventDefault within a passive event handler. See discussion here: Support Passive Event Listeners facebook/react#6436
  • Allow the style attribute to be passed in through props.

LOL

James Crosetto added 2 commits October 17, 2019 16:36
Improve performance of wheel events using animation frames.
c263f8f 
Fix warning about calling preventDefault within passive event handlers when using the mouse wheel.
Allow passing style attribute down to diagram widget.
Bump version number
2af8b70
@ghost ghost requested review from bzvestey and mechaffin October 17, 2019 23:41
bzvestey
bzvestey approved these changes Oct 17, 2019
View reviewed changes
Copy link

@bzvestey bzvestey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 975c10b into master Oct 18, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bzvestey @mechaffin