Additional realpath() fixes #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fhgwright
commented
Nov 8, 2024
fhgwright
commented
- Fix 10.6 non-POSIX realpath()
- Add test case demonstrating 10.6 non-POSIX bug.
The rework of the Makefile recipes dropped this, which impacts those test builds for non-default architectures. TESTED: ARCHFLAGS is now honored as intended.
This adds our allocating wrapper to the 10.6 non-POSIX case, which returns an unsafe buffer pointer when supplied with a nonexistent path and no buffer. Providing our own malloc()ed buffer avoids the problem. This only affects 32-bit builds, since 64-bit non-POSIX is nonexistent. The original flag is renamed in the process, with the original name now reflecting the combined need for the wrapper. Some whitespace cleanup is also applied to the other composite flag definitions. Updates README to reflect the fix. TESTED: Tests pass on all platforms, including newly added test case (next commit).
Although more thorough testing of various path cases would be useful, this one, which just tests a simple nonexistent relative path, is sufficient to demonstrate a bug in the 10.6 non-POSIX realpath(), which returns "success" via an unsafe pointer to an internal buffer. TESTED: Fails in known bad case without the fix; passes in all cases with the fix.
|
@mascguy The only remaining known |
mascguy
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.