-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ruby-devel: update to upstream, fix build on < 10.7 #24868
Conversation
Notifying maintainers: |
@macportsraf Do you think we can simply add a declaration for |
@barracuda156 I don't think just changing the header would be enough. legacysupport provides an implementation for fsetattrlist, not just a declaration, so I expect that we'd need to add an implementation of fgetattrlist as well as a declaration. Would you like me to start a pull request for it? I'm happy to give it a go. Note that the fsetattrlist implementation has no tests. But if we add an implementation of fgetattrlist we could probably add testing for both (i.e., set some attrs then get them and see if they are there). |
@macportsraf That would be great if you could help with this. Please. |
@kimuraw I have changed C standard fix here as well, and updated to the latest commit to include your fix for old clang-based systems. |
I've just created a pull request that adds |
Let me know when to commit this. FWIW, I think the fact that there may be gcc99 dependencies in some of the code (at least on gcc) is probably a bug that upstream should want fixed. |
@macportsbot Awesome, thank you! @pmetzger I do not know why MacPorts is adding c99 flag. Everything builds fine without it. |
Will make a new one, without |
Description
Earlier warnings are now errors with gcc14, and anyway these should have been fixed regardless:
-std=c99
which breaks inclusion oflgamma_r
.fgetattrlist
as being available where it is not (legacysupport
misleads autoconf, it seems).Also enable proper output on building C sources, this is a -devel port.
Type(s)
Tested on
macOS 10.6
Xcode 3.2
Verification
Have you
port lint --nitpick
?sudo port test
?sudo port -vst install
?