Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby-devel: update to upstream, fix build on < 10.7 #24868

Closed
wants to merge 7 commits into from

Conversation

barracuda156
Copy link
Contributor

Description

Earlier warnings are now errors with gcc14, and anyway these should have been fixed regardless:

  1. Drop -std=c99 which breaks inclusion of lgamma_r.
  2. Fix misdetection of fgetattrlist as being available where it is not (legacysupport misleads autoconf, it seems).

Also enable proper output on building C sources, this is a -devel port.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@kimuraw for port ruby-devel.

@barracuda156
Copy link
Contributor Author

@macportsraf Do you think we can simply add a declaration for fgetattrlist in legacy-support header like it is done for fsetattrlist?

@macportsraf
Copy link

@barracuda156 I don't think just changing the header would be enough. legacysupport provides an implementation for fsetattrlist, not just a declaration, so I expect that we'd need to add an implementation of fgetattrlist as well as a declaration. Would you like me to start a pull request for it? I'm happy to give it a go.

Note that the fsetattrlist implementation has no tests. But if we add an implementation of fgetattrlist we could probably add testing for both (i.e., set some attrs then get them and see if they are there).

@barracuda156
Copy link
Contributor Author

@macportsraf That would be great if you could help with this. Please.

@barracuda156
Copy link
Contributor Author

@kimuraw I have changed C standard fix here as well, and updated to the latest commit to include your fix for old clang-based systems.

@macportsraf
Copy link

macportsraf commented Jul 15, 2024

I've just created a pull request that adds fgetattrlist() to legacysupport (macports/macports-legacy-support#93).

@pmetzger
Copy link
Member

Let me know when to commit this. FWIW, I think the fact that there may be gcc99 dependencies in some of the code (at least on gcc) is probably a bug that upstream should want fixed.

@barracuda156
Copy link
Contributor Author

I've just created a pull request that adds fgetattrlist() to legacysupport (macports/macports-legacy-support#93).

@macportsbot Awesome, thank you!

@pmetzger I do not know why MacPorts is adding c99 flag. Everything builds fine without it.
With merging, let legacysupport have the fix merged, and then I can drop that hack from the PR.

@barracuda156
Copy link
Contributor Author

Will make a new one, without fgetattrlist hack and dropping unneeded C99.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants