Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add skipDIDToken to magic.oauth.getRedirectResult #862

Merged

Conversation

Ethella
Copy link
Member

@Ethella Ethella commented Mar 10, 2025

πŸ“¦ Pull Request

[Provide a general summary of the pull request here.]

Add return public address flag to remove the need of returning DID Token in the response

βœ… Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please 🚨 ONLY ADD ONE 🚨 of the following labels, failing to do so may lead to adverse versioning of your changes when published:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

Special Note

Please avoid adding any of the Priority labels as they conflict with the labels above ☝️

πŸ“¦ Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @magic-ext/[email protected]
# or 
yarn add @magic-ext/[email protected]

@Ethella Ethella added the major Increment the major version when merged label Mar 10, 2025
@Ethella Ethella self-assigned this Mar 10, 2025
@Ethella Ethella requested a review from a team as a code owner March 10, 2025 22:52
@Ethella Ethella changed the title add return public address add skipDIDToken to magic.oauth.getRedirectResult Mar 10, 2025
@Ethella Ethella added this pull request to the merge queue Mar 11, 2025
Merged via the queue into master with commit d63db16 Mar 11, 2025
6 checks passed
@Ethella Ethella deleted the PDEEXP-2299-create-return-public-address-in-sdk-to-oauth-verify branch March 11, 2025 01:24
@Ethella
Copy link
Member Author

Ethella commented Mar 11, 2025

πŸš€ PR was released in @magic-ext/[email protected] πŸš€

@Ethella Ethella added the released This issue/pull request has been released. label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Increment the major version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants