Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SQLite3 by checking for jsonb in migrations #117

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support SQLite3 by checking for jsonb in migrations #117

wants to merge 2 commits into from

Conversation

henrikbjorn
Copy link

For fun I tried the quick start guide and ran rpl -R 'jsonb' 'json' db/migrate and to my surprise maglev works perfectly fine with SQLite.

I have added a check for jsonb support in migrations. If not then fallback to json. This is the pattern followed by Spree, Pay etc.

@did
Copy link
Contributor

did commented Mar 6, 2025

👋 @henrikbjorn. This is really awesome, thanks!!!
I'm totally willing to merge it quickly at the condition to have some kind of tests in the CI by using the CI matrix feature to select sqlite as the DB provider for instance. How are the other projects doing?
Thanks again!

@did did added the enhancement New feature or request label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrikbjorn @did