Add Korean localization #1346
Merged
Add Korean localization #1346
+139
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
changed the title
|
I’ve repurposed this PR for adding a Korean localization from Transifex. Thanks for the translations, @tan-tran-ea! |
1ec5
commented
Apr 27, 2018
| @@ -48,6 +48,7 @@ The upcoming road or ramp destination is named according to the local or nationa | |||
| | Hebrew | ✅ | ✅ | — | ✅ | |||
| | Hungarian | ✅ | — | — | ✅ | |||
| | Italian | ✅ | ✅ | ✅ | ✅ | |||
| | Korean | ✅ | — | ✅ | ✅ | |||
There was a problem hiding this comment.
The sample applications currently won’t show anything in Korean, but any application that is localized into Korean will have the fully localized navigation UI.
Spoken instructions are marked as unavailable for now, until we release and deploy a version of the Directions API that incorporates Project-OSRM/osrm-text-instructions#243.
frederoni
approved these changes
Apr 30, 2018
1ec5
force-pushed
the
1ec5-tx-2018-04-27
branch
from
adff48a to
94b1ffc
Compare
bsudekum
approved these changes
Apr 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a Korean localization, courtesy of @tan-tran-ea. Updated a couple translations in Arabic and European Portuguese.
/cc @frederoni