Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Async Workers for Heavy Async. Tasks #38

Closed
wants to merge 2 commits into from
Closed

Conversation

daniel-j-h
Copy link

@daniel-j-h daniel-j-h commented Feb 16, 2017

This repository is great for getting people up to speed with Node bindings and Nan.

Let's switch over to Nan's AsncWorkers for async. tasks.
It's simpler, clearer and less error prone then doing it ourselves with uv.

Somewhat related: #5.

cc @springmeyer

@daniel-j-h
Copy link
Author

Fixed some remaining issues - Linux builds on Travis are green. Waiting for macOS builds (will take a while, will check tomorrow).

@springmeyer
Copy link
Contributor

Thanks for working in this! I'll test on os x later today.

@codecov-io
Copy link

codecov-io commented Feb 16, 2017

Codecov Report

Merging #38 into master will decrease coverage by -0.19%.
The diff coverage is 95.83%.

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   98.73%   98.55%   -0.19%     
==========================================
  Files           2        2              
  Lines          79       69      -10     
==========================================
- Hits           78       68      -10     
  Misses          1        1
Impacted Files Coverage Δ
src/hello_world.hpp 0% <ø> (ø)
src/hello_world.cpp 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e8575a...76d5370. Read the comment docs.

@daniel-j-h
Copy link
Author

Ping - just came across this again by accident, while checking out this project for its node-pre-gyp integration. What's the status here @springmeyer - anything blocking?

@GretaCB
Copy link
Contributor

GretaCB commented Jun 15, 2017

hey @daniel-j-h 👋 , thanks for getting this PR going! I'm currently refactoring the skel, and going to integrate AsyncWorkers in a new branch coming soon, stay tuned

@GretaCB GretaCB mentioned this pull request Jun 15, 2017
2 tasks
@daniel-j-h
Copy link
Author

Great, thank you! 👍

@GretaCB
Copy link
Contributor

GretaCB commented Jun 22, 2017

Implemented over at #46

@GretaCB GretaCB closed this Jun 22, 2017
@GretaCB GretaCB deleted the async-workers branch June 22, 2017 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants