-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Async Workers for Heavy Async. Tasks #38
Conversation
fbea83b
to
6941b26
Compare
6941b26
to
76d5370
Compare
Fixed some remaining issues - Linux builds on Travis are green. Waiting for macOS builds (will take a while, will check tomorrow). |
Thanks for working in this! I'll test on os x later today. |
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
- Coverage 98.73% 98.55% -0.19%
==========================================
Files 2 2
Lines 79 69 -10
==========================================
- Hits 78 68 -10
Misses 1 1
Continue to review full report at Codecov.
|
Ping - just came across this again by accident, while checking out this project for its node-pre-gyp integration. What's the status here @springmeyer - anything blocking? |
hey @daniel-j-h 👋 , thanks for getting this PR going! I'm currently refactoring the skel, and going to integrate AsyncWorkers in a new branch coming soon, stay tuned |
Great, thank you! 👍 |
Implemented over at #46 |
This repository is great for getting people up to speed with Node bindings and Nan.
Let's switch over to Nan's AsncWorkers for async. tasks.
It's simpler, clearer and less error prone then doing it ourselves with uv.
Somewhat related: #5.
cc @springmeyer