-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
io.js tests fail on windows #147
Comments
disabled in 3124486 just to keep appveyor green for node.js until this mystery is solved. |
I am almost sure that's nodejs/node#751. |
@Mithgol - thank you - that certainly looks like the problem. |
On nodejs/node#751 they're going to fix this problem on the engine's level, but it can also be fixed on a build tools' level — nodejs/node-gyp#564. (That's a good thing unless some bystander effect happens.) |
Okay. But I'm thinking this is not a major problem overall. I think this is only an issue for how the node-pre-gyp tests work and I can adapt (working on this now). The critical $ node -e "console.log(process.execPath)"
/Users/dane/.nvm/versions/io.js/v1.2.0/bin/iojs So, to recap: this should not prevent node-pre-gyp working for users of io.js at all. Right? |
Right. (Starting from nodejs/node-gyp#564 (comment) some comments seem to imply that |
fixed in #148 |
With io.js the node-pre-gyp tests that shell out to
npm test
for each test app fail on windows/appveyor withModule did not self-register.
https://ci.appveyor.com/project/Mapbox/node-pre-gyp/build/1.0.216/job/2psngm8nbqjl9w7g#L373
No idea yet what is going wrong.
The text was updated successfully, but these errors were encountered: