Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies #10

Merged
merged 45 commits into from
May 27, 2021
Merged

Upgrade dependencies #10

merged 45 commits into from
May 27, 2021

Conversation

xeptore
Copy link
Contributor

@xeptore xeptore commented Apr 1, 2021

Upgrade all dependencies to their latest version.

Closes #4.

xeptore added 30 commits March 31, 2021 19:11
@xeptore
build(deps): bump all dependencies to latest version
0d48620
@xeptore
build(deps): re-generate package-lock.json with npm@7
f19113f
@xeptore
chore(lint): migrate eslint prettier plugin configuration
ff051f3 
migrate eslint prettier plugin and configuration plugin configuration due to breaking changes
@xeptore
style(lint): lint files
f040981 
lint all files by executing 'lint' npm script
@xeptore
style(lint): fix eslint linting warning
34c4096
@xeptore
build(deps): add @commitlint/types package
6e9d4b2 
it contains all TypeScript type declarations for commitlint package types
@xeptore
refactor(engine): adapt with dependencies upgrade
aeb2361
@xeptore
refactor(engine): improve typing
e6f7a3a
@xeptore
refactor(utils): adapt utils with dependencies upgrade
64700ed
@xeptore
refactor(body-maker): adapt with dependencies upgrade
a71f7c9
@xeptore
refactor(footer-maker): adapt with dependencies upgrade
449e053
@xeptore
refactor(scope-maker): adapt with dependencies upgrade
2e2fd7f
@xeptore
refactor(subject-maker): adapt with dependencies upgrade
9b902cb
@xeptore
refactor(type-maker): adapt with dependencies upgrade
141555a
@xeptore
refactor(commit-template): adapt with dependencies upgrade
f1ba279
@xeptore
style(ts): use import type syntax
f80eb0f
@xeptore
refactor(filters): adapt with dependencies upgrade
1ce5c17
@xeptore
style(ts): use import type syntax
70b8f5e
@xeptore
refactor(validators): adapt with dependencies upgrade
b680b15
@xeptore
refactor(when): adapt with dependencies upgrade
82fe9c8
@xeptore
refactor(test/body-maker): adapt with dependencies upgrade
471df38
@xeptore
refactor(test/scope-maker): adapt with dependencies upgrade
57b5baf
@xeptore
refactor(test/subject-maker): adapt with dependencies upgrade
fa578f4
@xeptore
refactor(test/type-maker): adapt with dependencies upgrade
d592206
@xeptore
refactor(test/commit-template): adapt with dependencies upgrade
aeadd04
@xeptore
refactor(test/filters): adapt with dependencies upgrade
4a7a19b
@xeptore
refactor(test/utils): adapt with dependencies upgrade
15514e0
@xeptore
refactor(test/validators): adapt with dependencies upgrade
764bd86
@xeptore
refactor(test/when): adapt with dependencies upgrade
3774052
@xeptore
build(npm): add prepare script
a77e01b 
initialize husky to install git commit hooks in prepare script
xeptore added 7 commits March 31, 2021 23:31
@xeptore
chore(git): add husky pre-commit hook script files
e709421
@xeptore
chore: migrate husky to its latest version
b9b0af0
@xeptore
build: remove git-add from lint-staged scripts
e0f02ff
@xeptore
style: exclude parentheses around sole arrow function parameters
d3c9aa4 
as discussion at: https://github.com/xeptore/commitiquette/pull/1#pullrequestreview-626076153 we
decided to remove prentheses around sole arrow function paraemeters.
a re-linting commit will be issued in the next commit.
@xeptore
style: lint all files
72797a8
@xeptore
fix: relax nullable rule checks
26a9e8b 
as the result of disscussion at:
https://github.com/xeptore/commitiquette/pull/1#pullrequestreview-626057744,
we decided to revert back to '== null' checks.
@xeptore
Merge pull request #1 from xeptore/upgrade-deps
cd0e0fe 
Upgrade Dependencies
@martinmcwhorter
Copy link
Owner

It looks like tests failed in relation to full-stop.

I think commitlint used to require a provided full-stop char, but then they removed that param. If I remember right.

@xeptore
Copy link
Contributor Author

xeptore commented Apr 1, 2021

About the failing tests, there is a bug I found in some rule configuration type declarations of @commitlint/types package. I made a PR yesterday that fixes this bug here: conventional-changelog/commitlint#2534, and at the time of writing this, it seems it will be accepted and possibly merged soon.

@xeptore xeptore closed this Apr 1, 2021
@xeptore xeptore reopened this Apr 1, 2021
@xeptore xeptore marked this pull request as draft April 9, 2021 11:01
xeptore added 4 commits April 9, 2021 15:33
@xeptore
build(deps): update typescript
f2406d7 
typescript 4.2.3 => 4.2.4
@xeptore
build(deps): update tslib
afb06f2 
tslib 2.1.0 => 2.2.0
@xeptore
build(deps): update @typescript-eslint
b94270c 
@typescript-eslint/eslint-plugin 4.20.0 => 4.21.0
@typescript-eslint/parser 4.20.0 => 4.21.0
@xeptore
build(deps): update @commitlint
55ecac4 
@commitlint/cli 12.0.1 =>  12.1.1
@commitlint/config-conventional 12.0.1 =>  12.1.1
@commitlint/load 12.0.1 =>  12.1.1
@commitlint/types 12.0.1 =>  12.1.1
@xeptore
Copy link
Contributor Author

xeptore commented Apr 9, 2021

conventional-changelog/commitlint#2534 has been merged. Waiting for the new version publish to update our dependencies.

@martinmcwhorter
Copy link
Owner

martinmcwhorter commented May 27, 2021 •
edited
Loading

@xeptore I believe the changes you made to commitlint have been released. Can you update this PR with an updated commitlint version?

@xeptore xeptore marked this pull request as ready for review May 27, 2021 16:41
@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #10 (b9ce146) into master (c3f8172) will increase coverage by 0.44%.
The diff coverage is 85.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   79.03%   79.47%   +0.44%     
==========================================
  Files          12       12              
  Lines         372      380       +8     
  Branches       77       88      +11     
==========================================
+ Hits          294      302       +8     
+ Misses         78       77       -1     
- Partials        0        1       +1
Flag Coverage Δ
unittests 79.47% <85.55%> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/engine.ts 0.00% <0.00%> (ø)
src/index.ts 0.00% <0.00%> (ø)
src/prompts/footer-maker.ts 0.00% <0.00%> (ø)
src/commit-template.ts 100.00% <100.00%> (ø)
src/filters.ts 100.00% <100.00%> (ø)
src/prompts/body-maker.ts 100.00% <100.00%> (ø)
src/prompts/scope-maker.ts 97.77% <100.00%> (+0.05%) ⬆️
src/prompts/subject-maker.ts 100.00% <100.00%> (ø)
src/prompts/type-maker.ts 100.00% <100.00%> (ø)
src/utils.ts 100.00% <100.00%> (ø)
... and 2 more

@xeptore
Copy link
Contributor Author

xeptore commented May 27, 2021

@martinmcwhorter, all outdated dependencies, including commitlint were updated. It seems it is a bad credential error that causes the Node.js CI job to fail, and everything else is working fine.

@martinmcwhorter martinmcwhorter merged commit fbde556 into martinmcwhorter:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmcwhorter martinmcwhorter martinmcwhorter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

package lock dependencies
2 participants
@xeptore @martinmcwhorter