Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clickable nodes style in mermaid #169

Merged
merged 1 commit into from
Dec 21, 2018
Merged

fix clickable nodes style in mermaid #169

merged 1 commit into from
Dec 21, 2018

Conversation

leonstafford
Copy link

Hi @matcornic,

Thanks again for this awesome theme!

As per the referenced #168, we can create clickable nodes in mermaid as per the demo site, but the cursor is not being styled correctly. This sorts that out.

  • add CSS ruleset for clickable nodes
  • replace JS with latest minified from mermaidjs.github.io

@leonstafford leonstafford changed the title fixes #168 - style clickable nodes in mermaid fix clickable nodes style in mermaid Oct 2, 2018
@matalo33
Copy link
Contributor

matalo33 commented Oct 8, 2018

screenshot 2018-10-08 at 16 19 02
Any idea why the styling changes on the 1st example in the exampleSite after applying this patch?

(Sorry, ignore the drop shadow, that's me lining up 2 chrome windows. The styling I'm referring to is the bolder text and borders.)

@matalo33
Copy link
Contributor

Removed update to mermaid.js from this PR

@matalo33 matalo33 merged commit 0ed4fe1 into matcornic:master Dec 21, 2018
@matalo33 matalo33 added enhancement Improvements to existing features and removed need user feedback labels Jan 28, 2019
gr1m0h pushed a commit to gr1m0h/hugo-theme-learn that referenced this pull request Mar 7, 2021
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this pull request Jan 23, 2024
- currently the only option until matcornic#169 is implemented
- also mandatory for printing
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this pull request Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this pull request Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this pull request Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this pull request Jan 23, 2024
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this pull request Jan 23, 2024
be a role model and adhere to the docs
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this pull request Jan 23, 2024
as it may happen to be called with string options in case of documented `partial (compat)` mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants