Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate icon and fix incorrect favicon type #227

Merged
merged 1 commit into from
Feb 19, 2019
Merged

remove duplicate icon and fix incorrect favicon type #227

merged 1 commit into from
Feb 19, 2019

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Jan 4, 2019

image/x-icon is only for .ico files. image/png should be used for .png

@matalo33
Copy link
Contributor

As per https://perishablepress.com/everything-you-ever-wanted-to-know-about-favicons/ should the type actually be "image/ico"?

@matalo33 matalo33 added enhancement Improvements to existing features need user feedback labels Feb 17, 2019
@coliff
Copy link
Contributor Author

coliff commented Feb 18, 2019

It'd only be "image/ico" if the file extension was .ico

@matalo33
Copy link
Contributor

A part of the page I linked mentions this:

If your favicon is formatted as .gif, .jpg, or .png, the correct MIME type is “image/ico,” as represented by type="image/ico"

You may indeed be correct and the type should be image/png, I just would like to be sure.

@coliff
Copy link
Contributor Author

coliff commented Feb 19, 2019

Yep, I'm pretty certain that image-png is correct. The W3 Org says so https://www.w3.org/TR/PNG/#A-Media-type and that's what Bootstrap, the most popular CSS framework uses: https://github.com/twbs/bootstrap/blob/master/site/_includes/favicons.html

@matalo33
Copy link
Contributor

Thanks @coliff 👍

@matalo33 matalo33 merged commit 4fc4354 into matcornic:master Feb 19, 2019
@coliff coliff deleted the patch-3 branch February 19, 2019 10:37
gr1m0h pushed a commit to gr1m0h/hugo-theme-learn that referenced this pull request Mar 7, 2021
remove duplicate icon and fix incorrect favicon type
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants