Update menu.html to include the check icon #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm seeing issues where the check icon is not rendered. It seems like it this `<i></i>` element was mistakenly missing the additional class required in order for it to actually render the font-awesome check icon. So, I added the `fa-check` class locally and now it works as expected.
gr1m0h
pushed a commit
to gr1m0h/hugo-theme-learn
that referenced
this pull request
Mar 7, 2021
Update menu.html to include the check icon
maxatome
pushed a commit
to maxatome/hugo-theme-learn
that referenced
this pull request
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, @matcornic -- I just wanted to say that this is a beautiful HUGO template - thank you for providing this.
I'm seeing issues where the check icon is not rendered. It seems like it this
<i></i>element was mistakenly missing the additional class required in order for it to actually render the font-awesome check icon. So, I added thefa-checkclass locally and now it works as expected.