Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update disabled site message to include link to site settings #23134

Merged
merged 5 commits into from
Mar 17, 2025
Merged

Conversation

nathangavin
Copy link
Contributor

Description:

Fix minor spelling mistakes in GDPR tool - disabled sites message. Also added link to site settings where user can enable Visitor logs or Visitor Profiles. Link is not dynamic, currently always goes to global site settings.

Review

Sorry, something went wrong.

nathangavin and others added 2 commits March 17, 2025 16:31
@nathangavin nathangavin requested a review from a team March 17, 2025 04:45
@nathangavin nathangavin added the Needs Review PRs that need a code review label Mar 17, 2025
sgiehl added 2 commits March 17, 2025 14:25

Verified

This commit was signed with the committer’s verified signature.
sgiehl Stefan Giehl

Verified

This commit was signed with the committer’s verified signature.
sgiehl Stefan Giehl
@sgiehl sgiehl dismissed their stale review March 17, 2025 14:14

updated

@sgiehl sgiehl requested a review from a team March 17, 2025 14:14
@sgiehl sgiehl added this to the 5.4.0 milestone Mar 17, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will wait for the tests to finish and merge then.

@sgiehl
Copy link
Member

sgiehl commented Mar 17, 2025

Test failures are unrelated.

@sgiehl sgiehl merged commit d9b8b4a into 5.x-dev Mar 17, 2025
23 of 27 checks passed
@sgiehl sgiehl deleted the dev-18997 branch March 17, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Development

Successfully merging this pull request may close these issues.

None yet

5 participants