Add a mechanism to remind users to rotate personal auth tokens #23172
+768
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caddoo
reviewed
Mar 26, 2025
plugins/UsersManager/AuthTokenNotifications/AuthTokenNotification.php
Outdated
Show resolved
Hide resolved
plugins/UsersManager/AuthTokenNotifications/AuthTokenNotification.php
Outdated
Show resolved
Hide resolved
plugins/UsersManager/AuthTokenNotifications/AuthTokenNotification.php
Outdated
Show resolved
Hide resolved
plugins/UsersManager/AuthTokenNotifications/AuthTokenNotification.php
Outdated
Show resolved
Hide resolved
sgiehl
requested changes
Mar 27, 2025
plugins/UsersManager/AuthTokenNotifications/AuthTokenNotification.php
Outdated
Show resolved
Hide resolved
plugins/UsersManager/AuthTokenNotifications/AuthTokenNotification.php
Outdated
Show resolved
Hide resolved
plugins/UsersManager/AuthTokenNotifications/AuthTokenProviderInterface.php
Outdated
Show resolved
Hide resolved
plugins/UsersManager/AuthTokenNotifications/AuthTokenProviderInterface.php
Outdated
Show resolved
Hide resolved
|
@sgiehl I've changed the responsibilities a bit, added new interface for the token notification and made it all a bit more reusable and extendable. Please have another look. |
michalkleiner
added
Enhancement
sgiehl
previously requested changes
Mar 28, 2025
plugins/UsersManager/TokenNotifications/TokenNotificationInterface.php
Outdated
Show resolved
Hide resolved
…types other than email, simplify token provider, remove callbacks
mneudert
requested changes
Apr 3, 2025
plugins/UsersManager/TokenNotifications/TokenProviderInterface.php
Outdated
Show resolved
Hide resolved
|
Thanks for your feedback @mneudert, all should be addressed. |
michalkleiner
changed the title
mneudert
reviewed
Apr 10, 2025
Co-authored-by: Marc Neudert <[email protected]>
mneudert
reviewed
Apr 11, 2025
mneudert
approved these changes
Apr 11, 2025
|
Thanks for the reviews everyone! I'll leave the branch open until internal QA is done on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The PR adds a scheduled task, new config and a mechanism to send notification email to users when their tokens haven't been rotated over the configured number of days.
Review