Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAQ refers to file that was replaced #592

Closed
timcoote opened this issue Oct 29, 2023 · 2 comments
Closed

FAQ refers to file that was replaced #592

timcoote opened this issue Oct 29, 2023 · 2 comments

Comments

@timcoote
Copy link

FAQ refers to the file ireland.py as an example of how to caches country shapes (to paraphrase the statement). This file was replaced by hires.py some while ago.
@molinav
Copy link
Member

molinav commented Nov 24, 2023

Hi, @timcoote! Thanks for reporting the issue. You are totally right. In addition, I checked the hires.py and it is a bit misleading, because the pickled Basemap instance is loaded as m2 but the next lines of code use m, which is the original Basemap instance, and it should be m2 instead. I will correct all this now.

molinav added a commit that referenced this issue Nov 24, 2023
@molinav
Fix reference to missing example in FAQ
87bebc5 
Solves GitHub issue #592.
@molinav
Copy link
Member

molinav commented Nov 24, 2023

The corrections are pushed to the hotfix branch for basemap 1.3.9. Thanks again!

@molinav molinav closed this as completed Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timcoote @molinav