Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should web hooks run on a separate domain? #10

Closed
QuLogic opened this issue Mar 11, 2022 · 1 comment
Closed

Should web hooks run on a separate domain? #10

QuLogic opened this issue Mar 11, 2022 · 1 comment

Comments

@QuLogic
Copy link
Member

QuLogic commented Mar 11, 2022

When initially spinning up the droplet, I put it on do.matplotlib.org so we could test load a bit. I also configured all web hooks using that domain.

Now that matplotlib.org is pointing to the droplets, I modified Caddy to serve the same thing from both domains so that nothing breaks. However, that's a bit redundant, and we don't really need CF to be CDN'ing things twice (though I don't expect anyone to be accessing the duplicated subdomain.)

We can update the web hooks to point to matplotlib.org easily, but I wonder if we should leave them on a separate domain still? They'd still be served by the same server, but that would silo off the paths just in case we needed them (though that's unlikely).

@tacaswell
Copy link
Member

I would leave these on a separate domain for the webhooks to keep the "reads" and the "writes" separate.

QuLogic added a commit to QuLogic/matplotlib.org that referenced this issue Mar 29, 2022
And thus drop the mirroring of the main site to the webhook domain and
vice versa.

Fixes matplotlib#10
QuLogic added a commit to QuLogic/matplotlib.org that referenced this issue Mar 29, 2022
And thus drop the mirroring of the main site to the webhook domain and
vice versa.

Fixes matplotlib#10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants