-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CallNotifyEvent to support matrixRTC ringing #3878
Conversation
Signed-off-by: Timo K <[email protected]>
Signed-off-by: Timo K <[email protected]>
7e76cf4
to
e7ac459
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bulk of this change seems to be adding the session ID I think. I see the desire to export a common type for the notify events in js-sdk but it seems a bit weird for it to just export the type and then never actually use it?
@@ -78,6 +78,9 @@ export type MatrixRTCSessionEventHandlerMap = { | |||
* This class doesn't deal with media at all, just membership & properties of a session. | |||
*/ | |||
export class MatrixRTCSession extends TypedEventEmitter<MatrixRTCSessionEvent, MatrixRTCSessionEventHandlerMap> { | |||
// The session Id of the call, this is the call_id of the call Member event. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make this clear that this is only for use within the client and won't necessarily be the same between different clients or the same client restarted. Also probably want docs on the getter as that's where the public-facing API is.
and probably, "the oldest member event at the time the MatrixRTCSession object was created", although having read further I guess this isn't really correct either. "The first membership the MatrixRTCSession sees?"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually reading the react-sdk PR for context, isn't this just callId
? ie. the discriminator used to identify different user calls in the same room? I would just call it callId
rather than making up new terminology for it? The callIds for memberships in a session must be the same by definition, or they would belong in a different session.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes exactly this is just the call_id
from the matrix rtc session.
Since the MatrixRTCSession object is very generic I felt like having call specifics in here is odd.
Signed-off-by: Timo K <[email protected]>
This adds the
CallNotify
event type and the correspondingICallNotifyContent
Also this adds a sessionId to matrixRTCSessions. The sessionId is the value of call_id of the first membership. The memberships for a session are filtered by that id. So we can take either membership to calculate the sessionId
Checklist
Here's what your changelog entry will look like:
✨ Features