Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax version requirements for pyfunctional and numpy #44

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

dale-stewart
Copy link
Contributor

This change allows tests to pass using Python 3.11.1 by allowing a more recent version of pyfunctional, and prevents a version conflict with numpy in our usage of this tool. Tests also pass using Python 3.8, 3.9, and 3.10 .

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 98.40% // Head: 98.40% // No change to project coverage 👍

Coverage data is based on head (2a1aa19) compared to base (5941877).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files           8        8           
  Lines         688      688           
=======================================
  Hits          677      677           
  Misses         11       11           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dale-stewart
Copy link
Contributor Author

Since merging is blocked due to the unsigned commit, how would you like to proceed? Do I need to create another pull request with a signed commit? Because the change is so small, you are welcome to just incorporate the changes if that is easier.

@matsoftware
Copy link
Owner

Let me relax the changes, I'll deploy a new version soon, thanks

@matsoftware matsoftware merged commit e776b86 into matsoftware:master Mar 17, 2023
@dale-stewart
Copy link
Contributor Author

Thanks! I have incorporated the new version, and it is working well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants