Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class << self syntax support #1009

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Add class << self syntax support #1009

merged 1 commit into from
Aug 24, 2020

Conversation

mbj
Copy link
Owner

@mbj mbj commented Aug 2, 2020

Followup to #1000 with my edits to get it merge ready.

@mbj mbj force-pushed the add/metaclass-syntax-support branch from 45ff519 to fcae7d6 Compare August 2, 2020 21:47
@mbj mbj force-pushed the add/metaclass-syntax-support branch 3 times, most recently from b9de8a6 to 475e96c Compare August 24, 2020 13:33
@mbj mbj changed the title Add class << self syntax to singleton matcher specs Add class << self syntax support Aug 24, 2020
@mbj mbj force-pushed the add/metaclass-syntax-support branch from 475e96c to 1283f8e Compare August 24, 2020 13:34
@mbj
Copy link
Owner Author

mbj commented Aug 24, 2020

@telyn I merge this once green. I pushed a branch https://github.com/mbj/mutant/tree/add/metaclass-syntax-support-for-feedback for you to review the changes I did to your commit in a fine grained way.

There where lots of small things I'd like to change and it was far easier to change them than to flag them individually. Nothing on your semantics is changed, but I think its more maintainable this way.

If you have any question / feedback on my changes let me know.

@mbj mbj force-pushed the add/metaclass-syntax-support branch 2 times, most recently from 7f8953a to 7e7e434 Compare August 24, 2020 14:27
@mbj mbj self-assigned this Aug 24, 2020
@mbj mbj merged commit c1a98dc into master Aug 24, 2020
@mbj mbj deleted the add/metaclass-syntax-support branch August 24, 2020 14:32
@mbj
Copy link
Owner Author

mbj commented Aug 24, 2020

@telyn This change was released in 0.9.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants