Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test failure rendering for minitest #1153

Merged
merged 1 commit into from
Dec 12, 2020
+7 −0
Merged

Add test failure rendering for minitest #1153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Changelog.md
View file
Original file line number Diff line number Diff line change
@@ -14,6 +14,11 @@

* Fix matching non existing constants.

* [#1153](https://github.com/mbj/mutant/pulls/1153)

* Improve minitest integration to also render minitest failures in reports.
This is useful when reacting to noop errors.

# v0.10.17 2020-12-09

* Fix low frequency stuck isolation reads.
2 changes: 2 additions & 0 deletions lib/mutant/integration/minitest.rb
View file
Original file line number Diff line number Diff line change
@@ -95,6 +95,8 @@ def call(tests)
break unless test.call(reporter)
end

reporter.report
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minitest integration itself does not have a full mutation covering test right now. It only has integration tests.

This is for the reason mutant (at this point) is not prepared to load multiple integrations the same time, and as mutant itself requires rspec on itself this is a bit of a tie.

This situation should improve in the future.


Result::Test.new(
passed: reporter.passed?,
tests: tests,