Remove #eql? -> #equal? mutation
#1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgollahon
force-pushed
the
remove-eql-equal-mutation
branch
from
0bc67a2 to
93720ac
Compare
|
@mbj I am assuming you would prefer to keep the other mutations that include |
dgollahon
force-pushed
the
remove-eql-equal-mutation
branch
from
93720ac to
152d812
Compare
- This mutation has become very frustrating to deal with in certain situations. Notably, due to frozen string literals everywhere matching on `#equal?` one must ensure tests use unfrozen strings using `+` or other similar hacks. I also think that `#eql?` -> `#equal?` has very limited value in most situations. - NOTE: I have left in mutations to `equal?` as long as there are alternatives to `equal?` in the possible mutations.
dgollahon
force-pushed
the
remove-eql-equal-mutation
branch
from
152d812 to
b075ec0
Compare
mbj
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#equal?one must ensure tests use unfrozen strings using+or other similar hacks. I also think that#eql?->#equal?has very limited value in most situations.equal?as long as there are alternatives toequal?in the possible mutations so it is not forced over#eql?.