Remove invalid mutations to invalid syntax #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbj
force-pushed
the
fix/invalid-mutation
branch
from
5747743 to
7482745
Compare
mbj
force-pushed
the
fix/invalid-mutation
branch
from
7482745 to
75d3772
Compare
mbj
commented
Aug 29, 2021
| emit_left_mutations | ||
|
|
||
| emit_left_mutations do |mutation| | ||
| !(n_irange?(mutation) || n_erange?(mutation)) || !mutation.children.fetch(1).nil? |
There was a problem hiding this comment.
Endless ranges to the left of an || are invalid syntax. Welcome to ruby syntax design.
[Fix #1244] * Rubies syntax is not easily composable in all cases. * Unparser should NOT make up for cases where mutant emits invalid AST (that on the first glance should be valid, as its just promoting expressions).
mbj
force-pushed
the
fix/invalid-mutation
branch
from
75d3772 to
7feadca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(that on the first glance should be valid, as its just promoting
expressions).