Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Formal syntax" for @font-face/src #26133

Merged
merged 5 commits into from
Apr 13, 2023
Merged

Conversation

yarusome
Copy link
Contributor

@yarusome yarusome commented Apr 12, 2023

Description

This PR replaces the content of the "Formal Syntax" section on the @font-face/src page with the {{CSSSyntax}} macro.

Since the spec uses "see prose" as the value of this descriptor, I did the following:

  1. Copy the current prose from the spec;
  2. Fake the format like other "Formal syntax" sections, e.g. the one on the grid-template.

The second step seems suboptimal, though.

Motivation

Additional details

See w3c/csswg-drafts#7632 for the src syntax definition.

Related issues and pull requests

Fixes mdn/data#521.

@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Apr 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 12, 2023

Preview URLs

(comment last updated: 2023-04-13 05:47:11)

@yarusome yarusome changed the title Modernize "Formal syntax" for @font-face/src Update "Formal syntax" for @font-face/src Apr 12, 2023
@yarusome yarusome marked this pull request as ready for review April 12, 2023 02:17
@yarusome yarusome requested a review from a team as a code owner April 12, 2023 02:17
@yarusome yarusome requested review from estelle and removed request for a team April 12, 2023 02:17
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit 2f6c141 into mdn:main Apr 13, 2023
@yarusome yarusome deleted the font-face-src branch April 13, 2023 10:17
Mehrm0 pushed a commit to Mehrm0/content that referenced this pull request Apr 14, 2023
* Modernize "Formal syntax"

* Copy from the spec instead

* Formatting

* Formatting

* code syntax

---------

Co-authored-by: Estelle Weyl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with "@font-face/src": Update to latest CSS Fonts 4 syntax
2 participants