Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new export documents meilitool subcommand #4970

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

Kerollmops
Copy link
Member

This subcommand can be useful for extracting documents from an existing database.

@Kerollmops Kerollmops added this to the v1.12.0 milestone Oct 1, 2024
@Kerollmops Kerollmops requested a review from dureuill October 1, 2024 10:08
@Kerollmops Kerollmops requested a review from dureuill October 9, 2024 08:42
@Kerollmops Kerollmops force-pushed the meilitool-export-documents branch from 5adea6e to e63b33c Compare October 9, 2024 08:57
@Kerollmops
Copy link
Member Author

Hey @dureuill 👋 I fixed the issue and added support for vectors. Can you review that again? 🙂

@Kerollmops Kerollmops requested a review from dureuill October 14, 2024 07:51
dureuill
dureuill previously approved these changes Oct 15, 2024
Copy link
Contributor

@dureuill dureuill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can accept the changes as-is, but I'm wondering if we should maybe factor the logic to export the documents between meilitool and the dumps:

this logic changed multiple times (most recently, to inject vectors) and now exists in two different locations. If the next change updates the index-scheduler but forgets about meilitool, then we will get possibly hard to track inconsistencies when using the meilitool export-documents command.

If factoring the logic is too complicated due to them being in different crates not using the same types, maybe a comment on the index-scheduler implementation to also implement the meilitool implementation would be welcome.

What do you think?

@irevoire irevoire added the meilitool Anything related to meilitool label Nov 4, 2024
@curquiza curquiza modified the milestones: v1.12.0, v1.13.0 Dec 9, 2024
@curquiza curquiza changed the base branch from main to release-v1.13.0 January 27, 2025 16:37
@curquiza curquiza dismissed dureuill’s stale review January 27, 2025 16:37

The base branch was changed.

@Kerollmops Kerollmops force-pushed the meilitool-export-documents branch from 4e4d9e7 to f222792 Compare February 4, 2025 11:27

Verified

This commit was signed with the committer’s verified signature.
Kerollmops Clément Renault

Verified

This commit was signed with the committer’s verified signature.
Kerollmops Clément Renault

Verified

This commit was signed with the committer’s verified signature.
Kerollmops Clément Renault
@Kerollmops Kerollmops requested a review from dureuill February 6, 2025 09:37

Verified

This commit was signed with the committer’s verified signature.
Kerollmops Clément Renault
@Kerollmops Kerollmops requested a review from dureuill February 6, 2025 14:40
Copy link
Contributor

@dureuill dureuill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much!

bors merge

Copy link
Contributor

meili-bors bot commented Feb 6, 2025

Build succeeded:

@meili-bors meili-bors bot merged commit b7fdd95 into release-v1.13.0 Feb 6, 2025
10 checks passed
@meili-bors meili-bors bot deleted the meilitool-export-documents branch February 6, 2025 15:28
@meili-bot meili-bot added the v1.13.0 PRs/issues solved in v1.13.0 released on 2025-02-17 label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meilitool Anything related to meilitool v1.13.0 PRs/issues solved in v1.13.0 released on 2025-02-17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants