Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor release promotion to allow for missing builds #567

Merged
merged 7 commits into from
Mar 19, 2025

Conversation

mattkjames7
Copy link
Contributor

@mattkjames7 mattkjames7 commented Mar 17, 2025

Description

An issue with the previous release was that we had to exclude some images from Docker Hub. The updated workflow should allow some images to be missing from the RC, but for the remaining images to be correctly handled.

This action run shows that this works. The two failures are unrelated to this problem (AWS permissions challenges!), but the remaining successful jobs manage to push and arm image without there also having to be an amd image; or in one case it "fails successfully" if there is nothing to upload - which is the point of this PR.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Tests provided (unit / e2e)
  • Code documentation
  • README short description

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Handle missing RC images more gracefully without stopping the release altogether.
  • Link the documentation PR here
    • [Documentation PR link]
  • Tag someone from docs team in the comments

@mattkjames7 mattkjames7 marked this pull request as ready for review March 17, 2025 15:49
Copy link
Contributor

@imilinovic imilinovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mattkjames7 mattkjames7 merged commit 11d6880 into main Mar 19, 2025
10 checks passed
@mattkjames7 mattkjames7 deleted the update-promote-rc branch March 19, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants