Skip to content

feat: extend githubcredential CR status #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

rafalgalaw
Copy link
Collaborator

@rafalgalaw rafalgalaw commented Oct 23, 2024

fixes #188

  • shows to which repo, orgs or enterprises credentials are tied to
  • adds unit tests for credentials controller
image
apiVersion: v1
items:
- apiVersion: garm-operator.mercedes-benz.com/v1beta1
  kind: GitHubCredential
  metadata:
    creationTimestamp: "2024-10-23T13:00:43Z"
    finalizers:
    - garm-operator.mercedes-benz.com/credentials
    generation: 1
    labels:
      app.kubernetes.io/created-by: garm-operator
      app.kubernetes.io/instance: githubcredentials-sample
      app.kubernetes.io/managed-by: kustomize
      app.kubernetes.io/name: githubcredentials
      app.kubernetes.io/part-of: garm-operator
    name: github-pat
    namespace: garm-operator-system
    resourceVersion: "2005"
    uid: c3916b31-1e32-462b-9ac7-ba47fe94a5d6
  spec:
    authType: pat
    description: credentials for mercedes-benz github
    endpointRef:
      apiGroup: garm-operator.mercedes-benz.com
      kind: GitHubEndpoint
      name: github-enterprise
    secretRef:
      key: token
      name: github-pat
  status:
    apiBaseUrl: https://git.i.mercedes-benz.com
    baseUrl: https://git.i.mercedes-benz.com
    conditions:
    - lastTransitionTime: "2024-10-23T13:03:05Z"
      message: ""
      reason: ReconcileSuccess
      status: "True"
      type: Ready
    - lastTransitionTime: "2024-10-23T13:03:05Z"
      message: Successfully fetched GitHubEndpoint CR Ref
      reason: FetchingEndpointRefSuccess
      status: "True"
      type: EndpointReference
    - lastTransitionTime: "2024-10-23T13:03:05Z"
      message: ""
      reason: FetchingSecretRefSuccess
      status: "True"
      type: SecretReference
    id: 1
    repositories:
    - rthalho-test
    - e2e-testing
    uploadBaseUrl: https://git.i.mercedes-benz.com
kind: List
metadata:
  resourceVersion: ""

@rafalgalaw rafalgalaw changed the title Feat/githubcred status feat: extend githubcredential CR status Oct 23, 2024
@rafalgalaw rafalgalaw linked an issue Oct 23, 2024 that may be closed by this pull request
@rafalgalaw rafalgalaw merged commit 851dc4d into main Oct 24, 2024
4 of 5 checks passed
@rafalgalaw rafalgalaw deleted the feat/githubcred-status branch October 24, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the usage of a githubcredential should be reflected in the status
2 participants