fix: dublicate pool creation #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bavarianbidi
requested review from
maigl,
rafalgalaw and
H777K
as code owners
bavarianbidi
force-pushed
the
fix_duplicate_pool_creation
branch
2 times, most recently
from
2d1014c to
d966962
Compare
by setting the finalizer on pool level, it's necessary to immediatly end the reconciliation loop and add the pool CR back to the reconciliation loop. Otherwise the reconciliation will continue and a parallel reconciliation will happen where the pool status (with the pool id) is still empty - which leads to another pool creation Signed-off-by: Mario Constanti <[email protected]>
bavarianbidi
force-pushed
the
fix_duplicate_pool_creation
branch
from
d966962 to
0613360
Compare
H777K
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by setting the finalizer on pool level, it's necessary to immediately end the reconciliation loop and add the pool CR back to the reconciliation loop. Otherwise the reconciliation will continue and a parallel reconciliation will happen where the pool status (with the pool id) is still empty - which leads to another pool creation