BUG: fix creation of artifacts when the outdir does not exist #274
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PEP 517 does not specify whether sdist_directory or wheel_directory exist, and it may or may not do so. Some projects that create it in advance, before calling our build_sdist and build_wheel hooks: - pip - pyproject-build - gpep517 Some projects that do not create it: - pdm This may be a general problem in the ecosystem. Since nothing is specified, no one can assume anything -- the safest thing to do is have both the build backend and the build frontend create it, in order to ensure maximum compatibility between backends and frontends. To make matters even more fun, pdm will delete the entire directory before invoking the build hooks. So even if you previously ran pyproject-build, pdm will delete the directory, then let meson-python fail because it doesn't exist.
FFY00
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP 517 does not specify whether sdist_directory or wheel_directory exist, and it may or may not do so.
Some projects that create it in advance, before calling our build_sdist and build_wheel hooks:
Some projects that do not create it:
This may be a general problem in the ecosystem. Since nothing is specified, no one can assume anything -- the safest thing to do is have both the build backend and the build frontend create it, in order to ensure maximum compatibility between backends and frontends.
To make matters even more fun, pdm will delete the entire directory before invoking the build hooks. So even if you previously ran pyproject-build, pdm will delete the directory, then let meson-python fail because it doesn't exist.
Fixes #273