Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this, in 1password we now have on the
driver: clickhouse
credential an ENV section. This includes the usernamedefault
and password ofpassword
which is now being set in the docker compose file of this change.Here's everything running locally:
And tests:
The docs at https://hub.docker.com/r/clickhouse/clickhouse-server/ say that the default password is empty, but it seems it doesn't allow anyone to connect. So we set it in the docker image and the env of our test runner.
If you are testing locally, you can visit
http://localhost:8123/play?user=default#c2hvdyBkYXRhYmFzZXM= to see an interactive playground. Use default and password in the boxes top right.
Notably, now when we run this in CI, we run the following:
So i'm hopeful that clickhouse will be green now